Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade v1.14.0 #198

Merged
merged 115 commits into from
Aug 21, 2024
Merged

Conversation

chungquantin
Copy link
Collaborator

@chungquantin chungquantin commented Aug 16, 2024

Status: ✅ Compiled and built successfully

Direct changes

  • Add POV reclaim feature (introduced in v1.9.0 but there is a fix PR in v1.14.0).
  • Migrate XCMv5
  • Introduce the construct runtime V2
  • Use aggregated types for RuntimeFreezeReason: paritytech/polkadot-sdk@988103d
  • [#4730]: rpc upgrade jsonrpsee to v0.23.1
  • [#4769]: Use real rust type for pallet alias in runtime macro

Related changes

  • [#3679]: [pallet-contracts] bump wasmi to 0.32
  • [#4799]: network: Upgrade litep2p to v0.6.0

chungquantin and others added 30 commits August 12, 2024 16:46
…polkadot-v1.10.0' into chungquantin/chore-polkadot-v1.10.0
…polkadot-v1.11.0' into chungquantin/chore-polkadot-v1.11.0
Co-authored-by: Peter White <petras9789@gmail.com>
@Daanvdplas Daanvdplas self-requested a review August 19, 2024 12:29
Copy link
Collaborator

@Daanvdplas Daanvdplas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After comparing the runtime with the parachain template in the SDK on 1.14.

Runtime

Node

See base-parachain 1.9 upgrade and pop node 1.9 upgrade.

@chungquantin
Copy link
Collaborator Author

@Daanvdplas The POV reclaim feature is not added to this upgrade on purpose because there was a problem as discussed.

@Daanvdplas
Copy link
Collaborator

Could we add that in the description please? So that we have a reference to it

@Daanvdplas Daanvdplas self-requested a review August 19, 2024 13:09
@chungquantin
Copy link
Collaborator Author

chungquantin commented Aug 19, 2024

As we discussed in the 1.10.0 upgrade PR: https://github.com/paritytech/polkadot-sdk/pull/5371/files to whether we should add back the POV reclaim. From my understanding, it is fair to say that we can add back the feature in this v1.14.0 upgrade because there is a PR to fix the feature in this version: https://github.com/paritytech/polkadot-sdk/pull/5371/files

Hence, we can reimplement that for both devnet and testnet. What do you think?

cc: @al3mart @Daanvdplas @peterwht

@Daanvdplas
Copy link
Collaborator

There is also this migration: https://github.com/paritytech/polkadot-sdk/blob/946afaabd8244f1256f3aecff75e23c02937bd38/polkadot/xcm/pallet-xcm/src/migration.rs#L84

And this change in 1.13 (search for type MaxPageSize = ConstU32<{ 103 * 1024 }>;)

Would love to hear @al3mart opinion on both before putting it in.

@al3mart
Copy link
Collaborator

al3mart commented Aug 19, 2024

About the PoV reclaim feature I think we are OK to include it as part of this PR if we want to have it.
It definitely seems beneficial!

MigrateToLatestXcmVersion seems something that we have been missing for longer than this migrations even, so including it now would be good.

On MaxPageSize; our only open channel for the testnet right now is using a configuration of maxMessageSize: 8,192, which is well under our current value of 1 << 16, so we should be OK.
Though, if deploying a local environment as in pop up parachain -f networks/devnet.toml that would spin a relay that can values for that message size up to 1,048,576, so using a config of type MaxPageSize = ConstU32<{ 103 * 1024 }>; for the devnet runtime should put us just above it 👌
For the sake of simplicity I'd say that updating the config on both runtimes to type MaxPageSize = ConstU32<{ 103 * 1024 }>; would be the better option.

Copy link
Collaborator

@peterwht peterwht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So close! Great job.

As this is the last PR in the upgrade to 1.14, we should make sure all migrations are added.

try-runtime says we need a migration for XcmpQueue and pallet-contracts.

[ERROR runtime::frame-support] XcmpQueue: On chain storage version StorageVersion(4) doesn't match in-code storage version StorageVersion(5).
[ERROR runtime::frame-support] Contracts: On chain storage version StorageVersion(15) doesn't match in-code storage version StorageVersion(16).

@peterwht
Copy link
Collaborator

Let's go ahead and just add PovReclaim now that it has fixes. Just to note, we may have some changes in the future paritytech/polkadot-sdk#5234

@chungquantin
Copy link
Collaborator Author

  1. Migrations for contract, XCMP queue and XCM is added to the testnet runtime. Tested with try-runtime and works well.
	pallet_contracts::Migration<Runtime>,
	cumulus_pallet_xcmp_queue::migration::v5::MigrateV4ToV5<Runtime>,
	pallet_xcm::migration::MigrateToLatestXcmVersion<Runtime>,
  1. POV reclaim feature is added for both devnet and testnet
  2. Update the type parameter value of the HRMP channel max size

cc: @Daanvdplas @al3mart @peterwht

Before merging this PR, could you guys please help me to review this PR as well: #201 which fixes the integration tests.

Copy link
Collaborator

@peterwht peterwht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!! Glad to see this so close being done.

runtime/testnet/src/lib.rs Outdated Show resolved Hide resolved
@Daanvdplas Daanvdplas merged commit 84cf750 into developer Aug 21, 2024
8 checks passed
@Daanvdplas Daanvdplas deleted the chungquantin/chore-polkadot-v1.14.0 branch August 21, 2024 07:42
@Daanvdplas Daanvdplas mentioned this pull request Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants